Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#2066 Extract getSelectedIDs #18772

Merged
merged 1 commit into from
Nov 19, 2020
Merged

dev/core#2066 Extract getSelectedIDs #18772

merged 1 commit into from
Nov 19, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 14, 2020 •
edited
Loading

Overview

Decrease code duplication

This is an extension of #18768

I decided moving the IF into the function & making FALSE a return option was cleaner

Before

Repetitive lines

After

poof

Technical Details

Comments

@civibot
Copy link

civibot bot commented Oct 14, 2020

(Standard links)

@civibot civibot bot added the master label Oct 14, 2020
@eileenmcnaughton
dev/core#2066 Extract getSelectedIDs
56752ec 
This is an extension of civicrm#18768

I decided moving the IF into the function & making FALSE a return option was cleaner
@eileenmcnaughton
Copy link
Contributor Author

@monishdeb can you check this too? Fairly straight forward

@colemanw colemanw merged commit 05f7fac into civicrm:master Nov 19, 2020
@colemanw colemanw deleted the ids branch November 19, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw