Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/financial#152 [REF] Extract getMembershipID #18733

Merged
merged 1 commit into from
Oct 11, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 10, 2020

Overview

Minor extraction

Before

$ids['membership'] retrieved in inline code

After

$ids['membership'] retrieved in own function

Technical Details

Note that since NULL is valid we can just return the result of the query. Bypassing for
component=event doesn't provide enough value to justify relying on a url param
as opposed to just looking it up & feels very original-form-flow

Comments

Note that since NULL is valid we can just return the result of the query. Bypassing for
component=event doesn't provide enough value to justify relying on a url param
as opposed to just looking it up & feels very original-form-flow
@civibot
Copy link

civibot bot commented Oct 10, 2020

(Standard links)

@civibot civibot bot added the master label Oct 10, 2020
@mattwire mattwire merged commit babe6c2 into civicrm:master Oct 11, 2020
@eileenmcnaughton eileenmcnaughton deleted the aipn branch October 11, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants