Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search ext: misc cleanup & fixes #18723

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Oct 9, 2020

Overview

  • Fixes white on white button text by adding btn-default class
  • Fixes missing field names in the bulk-update action
  • Decouples searchActions from the main search controller
  • Ensures APIv4 returns both title & titlePlural to fix sorting & a display issue in Search UI
  • Misc cleanup

Before

image

image
After

image

image
Comments

The decoupling is in preparation for work on search displays, but doesn't hurt to have it in 5.31.

@civibot
Copy link

civibot bot commented Oct 9, 2020

(Standard links)

@civibot civibot bot added the master label Oct 9, 2020
@colemanw colemanw changed the base branch from master to 5.31 October 9, 2020 20:51
@civibot civibot bot added 5.31 and removed master labels Oct 9, 2020
- Fixes white on white button text by adding btn-default class
- Fixes missing field names in the bulk-update action
- Decouples searchActions from the main search controller
- Misc cleanup
@eileenmcnaughton
Copy link
Contributor

@colemanw OK - I think this is fine for the rc - the button part is a regression & the changes are all within the search code itself which is only just going into beta so a bit less rigidity is OK.

As I mentioned in gitlab I think there is a join regression :-(

@eileenmcnaughton
Copy link
Contributor

I think https://lab.civicrm.org/dev/core/-/issues/2109 is closable when this is merged

@seamuslee001 seamuslee001 merged commit b69c5c7 into civicrm:5.31 Oct 9, 2020
@seamuslee001 seamuslee001 deleted the crmSearchCleanup branch October 9, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants