dev/core#2102 Fix hang on event edit

[eileenmcnaughton]

Overview

Changing the address on an event causes hang (spinning logo)
Per https://lab.civicrm.org/dev/core/-/issues/2102

Before

Create an Event with a location & Save.
On Event configuration select 'Event Location' tab
Click Create new location radio
Enter address details
Click Save

-> Spinning logo. On reloading the page, 'Create new location' is still selected with no address details

After

Save as normal

Technical details

It was trying to add an address it had deleted - test covers the related issue too

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton can you please rebase this to ensure the set version commit isn't included

[eileenmcnaughton]

@seamuslee001 thanks - done

[seamuslee001]

@eileenmcnaughton test fails relate

CRM_Event_Form_ManageEvent_LocationTest.testCreateWithLocBlock
CRM_Event_Form_ManageEvent_LocationTest.testUpdateLocationBlock

[eileenmcnaughton]

trying again

[eileenmcnaughton]

Ok this is passing now - maybe @aydun will give it a spin for us & re-check?

[colemanw]

Tested & confirmed the bug & the fix works. Test passes.

[aydun]

Coleman got there first! All looks good on dmaster.