dev/core#1879 Fix inconsistent ability to view event information

[eileenmcnaughton]

Overview

Alternate to #17852

Before

A contact with 'view event info' who ALSO has permission via acl-given permission to view a specific will ONLY see that specific even in 'upcoming events' eg http://dmaster.local/civicrm/event/list?reset=1

After

Technical Details

@alifrumin I took another look at your PR - I would up being happier with this short-circuit approach which the code comments were already hinting at. I think your change might have allowed contacts with no event access some.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[alifrumin]

@eileenmcnaughton this works for me!!! I tested it and this fixes https://lab.civicrm.org/dev/core/-/issues/1879, I also looked at the code and it seems sensible to me.

[eileenmcnaughton]

@seamuslee001 @colemanw can one of your merge this reviewer's cut based on the above

[seamuslee001]

So this is potentially exposing events to ACLed users right but they won't be able to make changes to those events they don't have access to right / see the participants?

[eileenmcnaughton]

@seamuslee001 this makes it so that providing event info screens (icals, upcoming listing) only require 'view event info' - this is not affecting viewing participants

[eileenmcnaughton]

@seamuslee001 did ^^ answer your question?

[eileenmcnaughton]

@seamuslee001 I think this is mergeable based on review + answer

[seamuslee001]

ok I think as long as its documented that allows for view event info to bypass ACLs for the purposes for icals, and other feeds