dev/core#2093 - Fix red error box on new individual form and ltrim typos and doubling-up of class attribute

[demeritcowboy]

Overview

**** I think this needs to be in 5.31. If not merged by then I'll rebase to be against it. ****

https://lab.civicrm.org/dev/core/-/issues/2093

1. On dmaster.demo go to New Individual.
2. Red error box.

Technical Details

In a recent commit this line was added:

$fieldAttributes['class'] .= ltrim($fieldAttributes['class'] ?? '' . ' crm-select2');

It has a couple issues:

1. You can't use .= if the field isn't set yet, hence the red box.
2. The .= is a typo to begin with. If the field is already set it doubles-up the class.
3. Using ?? and . on the same line together requires brackets since the . always wins which leads to sneaky bugs. It turns out here it doesn't matter, but should have brackets. This isn't new to ?? - it used to come up sometimes with ? : too.

Comments

Has test. The existing version of a similar test didn't catch this because it didn't check custom fields.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Looks good to me merging

[demeritcowboy]

Thanks!