dev/core#1393 - distmaker - Skip new file "vendor/bin/cssmin" #18659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overview ---------------------------------------- This fixes the broken distmaker builds in `master`. The file `vendor/bin/cssmin` was recently added by way of `composer-compile-lib => cssmin`. We don't need it in the tarball, and it's a symlink, so trying to include breaks some consumers (like in https://lab.civicrm.org/dev/core/-/issues/1393). Technical Details ---------------------------------------- * Before (last release): `vendor/bin/cssmin` does not exist * Before (current master): `vendor/bin/cssmin` is created as symlink, copied to tarball * After (this commit): `vendor/bin/cssmin` is created on dev-builds but omitted from tarball
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes the broken distmaker builds in
master.The file
vendor/bin/cssminwas recently added by way ofcomposer-compile-lib => cssmin. We don't need it in the tarball, and it's a symlink, so trying to include breaks some consumers (like in https://lab.civicrm.org/dev/core/-/issues/1393).ping @seamuslee001
Technical Details
vendor/bin/cssmindoes not existvendor/bin/cssminis created as symlink, copied to tarballvendor/bin/cssminis created on dev-builds but omitted from tarball