dev/core#2046 Migrate BAO_Address::create towards standardisation #18658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
plenty of fails here |
Our standard expectation is that each BAO will have a create action that handles a single entity. For legacy reasons Address.create has special handling for multiple addresses. This extracts that handling into a separate function (legacyCreate) and updates the (very few) places currently calling create to call that. With this merged apis v3 & v4 can call Address.create - currently v3 is hard coded to call add and v4 bypasses the BAO altogher. The v4 api bypass means we are not managing is_primay integrity on v4 api calls
aeacfeb to
ae7397a
Compare
|
Ah yes - I still need to handle the case where the function is called for no reason.... - should work now |
|
@seamuslee001 and it's all happy now! |
|
Looks fine merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This moves us towards standardisation on BAO_Address::create - as part of a wider BAO standardisation fix - per https://lab.civicrm.org/dev/core/-/issues/2046 and also as part of identifying and addressing places in the code where is_primary integrity is mismanaged
Our standard expectation is that each BAO will have a create action that handles a single entity. For legacy
reasons Address.create has special handling for multiple addresses. This extracts that handling
into a separate function (legacyCreate) and updates the (very few) places currently calling create to
call that.
Before
BAO_Address::create does not operate like a standard crud action - it expects a key 'address' and creates multiple addresses based on that key
After
BAO_Address::create still accepts the key 'address' and if present the call will be redirected to the original code (in a function now called
legacyCreate. However, it also accepts 'normal' crud calls (in which case it acts as a pseudonym for addTechnical Details
With this merged apis v3 & v4 can call Address.create - currently v3 is hard coded to call add and
v4 bypasses the BAO altogether. The v4 api bypass means we are not managing is_primary integrity on v4 api calls
The next step would be to fix apiv4 to call this
Comments