dev/core#334 Use the current in use collation and character sets when…

[seamuslee001]

… creating new custom value tables

Overview

This changes the default attributes for new custom value tables to be dependant on the current in use collation.

Before

Only utf8 charset and utf8_unicode_ci collation were used to create new custom tables

After

Uses the relevant charset for the current collation of the civicrm_contact table.

ping @demeritcowboy @artfulrobot @mattwire

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Typo.
And I'd probably use stripos but that's less important.

[artfulrobot]

Yep, collaction → collation

[artfulrobot]

Great! Thanks for this, it was a real head scratcher for me doing migration work: I'd run the conversion script, think it was all utf8mb4 for sure, then my import script which adds custom fields would throw a 🔧 into the ⚙️ whenever it encountered a 🔧 or a ⚙️ or a 💅

• General standards
  • Explain (r-explain)
    • PASS : The goal/problem/solution have been adequately explained in the PR.
    • COMMENTS: See related SE question
  • User impact (r-user)
    • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.
  • Documentation (r-doc)
    • PASS: The changes do not require documentation.
    • COMMENTS: We might need to make some noise somewhere about re-running the system.utf8conversion if you've added custom fields since doing it.
  • Run it (r-run)
    • PASS: I have run the code (with the typo fixed) and it worked as expected for me on my utf8mb4 install: the table and text fields were created with utf8mb4 and suitable colaltion. (what is it about spelling that word?!)
• Developer standards
  • Technical impact (r-tech)
    • PASS: The change preserves compatibility with existing callers/code/downstream.
  • Code quality (r-code)
    • PASS: The functionality, purpose, and style of the code seems clear+sensible.
  • Maintainability (r-maint)
    • PASS: The change sufficiently improves test coverage, or the change is trivial enough that it does not require tests.
  • Test results (r-test)
    • UNREVIEWED - failing at mo because of the typo

[seamuslee001]

going to add Merge on pass based on @artfulrobot testing