[Test] Improve memory use #18639
Closed
[Test] Improve memory use #18639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
85d7f2a to
64a91ff
Compare
|
Definitely looks like a more selective approach is needed! |
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Sep 30, 2020
Cleaning up all objects seems a bit too much - but ensuring we re-set the DAO we create in this class should be a memory-friendly action civicrm#18639
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Sep 30, 2020
Cleaning up all objects seems a bit too much - but ensuring we re-set the DAO we create in this class should be a memory-friendly action civicrm#18639
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Oct 1, 2020
Cleaning up all objects seems a bit too much - but ensuring we re-set the DAO we create in this class should be a memory-friendly action civicrm#18639
|
Just to sum up what I learnt here - there is something that persists from test to test that improves efficiency - so better unsetting within tearDowns for the classes helps - but this sledge hammer is overkill |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
(just comparing locally at the moment)
https://tomnewby.net/posts/speed-up-phpunit-1-weird-trick/
Before
Running api_v3_ContactTest
After
Running api_v3_ContactTest
Technical Details
I'm not too sure how meaningful the time difference is as other activity on my laptop will have an impact - total time with jenkins will be more informative
Comments