dev/core#2035 Invoice template - show Amount paid even when it is fully paid #18602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
…ly paid In https://github.com/civicrm/civicrm-core/pull/16680/files?w=1#diff-b211e0dac858fdad5d480c118d645e0bR129 there was a change from 'show amount paid & due depending on pay-later status' to 'show amount paid & due depending on whether payment is due' This has been experienced as a regression and, being an invoice, there seems no reason to only change it sometimes. This change just alters the template that new installs will receive. If approved another step is needed to update existing installs (unless they have customised the template)
2fd8c13 to
5a2231b
Compare
|
Looks like @jitendrapurohit previously added a test on this code (yay) & it picked up the whitespace change :-) CRM_Contribute_Form_Task_InvoiceTest.testInvoiceForDueDate |
|
Tested this and it works as expected/desired. |
|
@seamuslee001 OK based on the above? Can add update part later as a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes invoice template so that Amount due displays (again) for fully paid invoices
https://lab.civicrm.org/dev/core/-/issues/2035
Before
In 5.24 this change altered the if from
'show amount paid & due depending on pay-later status' to 'show amount paid & due depending on whether payment is due'
This has been experienced as a regression and, being an invoice, there seems no reason to only change it sometimes.
After
Display of Paid amount / Amount Due 'always on'
Technical Details
This change just alters the template that new installs will receive. If approved another step is needed to update existing
installs (unless they have customised the template)
Comments
@magnolia61 @lcdservices @jitendrapurohit