Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core#2063: Don't throw a warning when public ext directory isn't found #18596

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

MegaphoneJon
Copy link
Contributor

https://lab.civicrm.org/dev/core/-/issues/2063

Overview

When the extension directory feed is offline, a warning is thrown in CiviCRM. However, this warning isn't actionable by the Civi administrator, and in 2020 this will never happen unless the directory is temporarily offline.

Before

There are currently no extensions on the CiviCRM public extension directory which are compatible with version 5.29.1. If you want to install an extension which is not marked as compatible, you may be able to download and install extensions manually (depending on access to your web server).

After

Silence

@civibot
Copy link

civibot bot commented Sep 25, 2020

(Standard links)

@civibot civibot bot added the master label Sep 25, 2020
@eileenmcnaughton
Copy link
Contributor

Looking at gitlab it seems @colemanw previously approved this & seems straight forward. Since I'm doing the dev-digest I'll include this but if no negative reaction can merge in a couple of days

@eileenmcnaughton eileenmcnaughton added the merge ready PR will be merged after a few days if there are no objections label Sep 25, 2020
@eileenmcnaughton
Copy link
Contributor

No reaction from the dev-digest -merging

@eileenmcnaughton eileenmcnaughton merged commit 9843970 into civicrm:master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants