Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve metadata on LineItem DAO #18521

Merged
merged 1 commit into from
Sep 20, 2020
Merged

Improve metadata on LineItem DAO #18521

merged 1 commit into from
Sep 20, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 18, 2020 •
edited
Loading

Overview

Adds pseudoconstants, labels to line item metadata

Before

Not defined

After

Pseudoconstants, html labels added

Technical Details

Comments

@colemanw - relates to #18520

@eileenmcnaughton
Improve metadata on LineItem DAO
8e17d9d 
Adds pseudoconstants, labels
@civibot
Copy link

civibot bot commented Sep 18, 2020

(Standard links)

@civibot civibot bot added the master label Sep 18, 2020
@pradpnayak
Copy link
Contributor

Looks good to me..

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 @colemanw we've had some eyes on here thanks to @pradpnayak

@seamuslee001 seamuslee001 merged commit 677418f into civicrm:master Sep 20, 2020
@seamuslee001 seamuslee001 deleted the fin_type branch September 20, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @pradpnayak @seamuslee001