CRM_Core_Resources::addBundle() - Fix handling of array inputs #18506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(This fixes a small bug in a new function added during this release -- part of civicrm#18247.) The signature of `addBundle()` optionally accepts an array/iterable -- if given, then it should add all the items from the array. For example: ```php Civi::resources()->addBundle(['foo', 'bar']); ``` Before ------ It adds `foo` but then bails out on `bar`. After ----- It adds both `foo` and `bar`.
|
(Standard links)
|
|
Test fails unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes a small bug in a new function added during this version-cycle -- part of #18247.
The signature of
addBundle()optionally accepts an array/iterable -- if given, then it should add all the items from the array. For example:Before
It adds
foobut ignoresbarandwhiz.After
It adds
foo,bar, andwhiz.