dev/core#2039 Fix OpenID::add to ensure is_primary is set

[eileenmcnaughton]

Overview

In my efforts to determine the the non-performant line of code that makes sure IM is set is
not required I edited tests to track down when is_primary is not correct & determined it
is missing from the add function - same as #18489 for IM

Before

Calling OpenID::add does not ensure contact has one primary

After

Calling OpenID::add does ensure contact has one primary - further establishing

civicrm-core/CRM/Core/BAO/Location.php

Line 73 in d357f22

self::checkPrimaryBlocks(CRM_Utils_Array::value('contact_id', $params));

as redundant

Technical Details

When creating 7 contacts with 7 contributions 18% of the total 393 queries were from that 1 line of code, 12% were for entities that were not created. My goal is to 'prove' the line of code can go - it turns out we needed to fix im & open_id before that is true (whether anyone uses them is an open question.....)

Comments

The 2 other commits are open as separate PRs - this can merge once they are merged
https://lab.civicrm.org/dev/core/-/issues/2039

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton needs a rebase

[eileenmcnaughton]

done