dev/event#42 [Ref] Separate url path calculation into the relevant classes #18486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Where I think we could go next is
& then we want to switch it - ie. preProcessCommon calls preProcessTask (& is deprecated) instead of vice versa |
eeb2378 to
f36fd0f
Compare
|
Neat :) Tested on local, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Separates functionality into the relevant classes between the participant search action & the main participant edit
Before
#18464 started the work of separating the 2 forms into 2 classes but only did if for one variable
After
This extends the above to cover the function assignUrlPath which was previously an if-else
Technical Details
https://lab.civicrm.org/dev/event/-/issues/42
Comments
@monishdeb - since the other is sorted...