Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E_NOTICE on contribution confirm page #18453

Merged

Conversation

demeritcowboy
Copy link
Contributor

Overview

The receipt_from_email value ended up missing the ?? NULL when it was recently converted from Array::value.

@civibot
Copy link

civibot bot commented Sep 13, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

ok without test - it would be possible to add a test on this one but we also acknowledge they are a bit more optional when fixing a regression as fixing is a bit less optional

@eileenmcnaughton eileenmcnaughton merged commit 56350e8 into civicrm:5.30 Sep 13, 2020
@demeritcowboy
Copy link
Contributor Author

Thanks!

@demeritcowboy demeritcowboy deleted the receipt-from-email-5.30 branch September 13, 2020 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants