CRM-9362: PCP 'Your Message' should use WYSIWYG

[MegaphoneJon]

Overview

The page where you edit your PCP settings has a textarea field where a wysiwyg field should be.

Before

After

Technical Details

It's literally a one-word change.

Comments

I don't know when this regressed - but it must have been in SVN times.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@MegaphoneJon was the with-html version in your db? We've hit problems with things like this before because it changes it from being saved as text to saved as html & other code not expecting html

[seamuslee001]

The original is also at least consistent with what is in the schema xml https://github.com/civicrm/civicrm-core/blob/master/xml/schema/PCP/PCP.xml#L80 if we wanted to change it (not the worst thing in the world) then the schema xml and also this line

civicrm-core/templates/CRM/PCP/Page/PCPInfo.tpl

Line 90 in f877625

{$pcp.page_text}

would need to be updated

[MegaphoneJon]

The screenshots are from a civibuild, so presumably it's what's in the sample data.

[eileenmcnaughton]

@KarinG you use pcps...

[KarinG]

That looks 👍 👍

[eileenmcnaughton]

Ok - well once @seamuslee001's comments are addressed I think we should merge it then. This isn't broadly used so agreement from @KarinG & @MegaphoneJon is OK from a concept-approved POV

[yashodha]

@MegaphoneJon
What about page_text field?
https://github.com/civicrm/civicrm-core/blob/master/CRM/PCP/Form/Campaign.php#L112

[MegaphoneJon]

@yashodha That's the field I'm changing. Am I misunderstanding the question?

[eileenmcnaughton]

I'm still nervous about existing saved text in this field - maybe on upgrade we check for presence of html tags & if none run through nl2br

[yashodha]

@MegaphoneJon
oh, I meant pcp_intro_text
https://github.com/civicrm/civicrm-core/blob/master/CRM/PCP/Form/Campaign.php#L93

[colemanw]

@MegaphoneJon can you make that change to the schema xml?

[eileenmcnaughton]

Discussed with @seamuslee001 & @kcristiano - merging this & @seamuslee001 will do a follow up with xml fix & a check if purify is needed in the tpl