dev/core#1987: Fix Drupal Base 'isFrontEndPage' function to consider Drupal public page for FE theme

[swastikpareek]

Overview

Drupal webform pages may have CiviCRM fields which internally initialize CiviCRM assets and was loading CiviCRM current theme assets. This is because CiviCRM doesn't have the logic for checking Drupal webform pages, whether they are FE pages or backend and since the logic is incomplete it loads the backend theme which because of this logic.

Extract

The whole idea is to tell Civicrm to treat non civicrm pages (Drupal public pages) which loads civicrm code to treat them as the front end page and apply front end theme. Currently it doesn't it treats these pages as backend pages and apply the civicrm backend theme on them.

Before

The CiviCRM was loading backend theme for the Drupal public web form pages which loads CiviCRM components.
Webform page which has civicrm enabled

After

The CiviCRM was loading the front theme for the Drupal public web form pages which loads CiviCRM components.
Webform page which has civicrm enabled

Technical Details

• isFrontEndPage is updated so that it treats Drupal public web form pages as CiviCRM public pages and load front end theme there.

Note

The before and after screenshots are added after adding a var_dump in getActiveThemeKey function in Themes.php.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@agileware-justin is this something you can get one of your team to test/ review?

[agileware-justin]

@eileenmcnaughton as long as you want this to be tested on Drupal 7?

[eileenmcnaughton]

@seamuslee001 that seems fine to me - do you think d8 is an issue here?

[demeritcowboy]

For drupal 8 I did a little clicking around. I didn't test webform, just that existing pages seemed to function the same, e.g. contribution pages and profiles get the front end theme, regular drupal nodes look normal, and civi pages look like civi pages.

[agileware-justin]

I've tested this patch and can't see any difference, sorry.

I think if you want someone to validate what this PR is doing with confidence, maybe include detailed steps to reproduce and for bonus points, have before / after screenshots.

[swastikpareek]

I've tested this patch and can't see any difference, sorry.

I think if you want someone to validate what this PR is doing with confidence, maybe include detailed steps to reproduce and for bonus points, have before / after screenshots.

@agileware-justin : I have added Before and After screenshots to the PR description and have also updated PR and added the extract of the problem and added a small note to compliment the details.

Let me know if you need further information to understand the issue better.

Thanks

[seamuslee001]

This makes sense to me, I think if there is no CRM Menu route then lets assume it is front end, merging