[REF] Remove unused lines from loadObjects #18389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadObjects is only called from one place. As we can see the contribution object is always passed in so we don't need to handle the possibility of it being anything other than a BAO (I tweaked the error handling around that line too to make it clearer where it was coming from)
|
(Standard links)
|
seamuslee001
reviewed
Sep 6, 2020
| CRM_Core_Error::debug_log_message("Could not find contribution record: {$contribution->id} in IPN request: " . print_r($input, TRUE)); | ||
| echo "Failure: Could not find contribution record for {$contribution->id}<p>"; | ||
| return FALSE; | ||
| throw new CRM_Core_Exception('Failure: Could not find contribution record for ' . (int) $contribution->id, NULL, ['context' => "Could not find contribution record: {$contribution->id} in IPN request: " . print_r($input, TRUE)]); |
There was a problem hiding this comment.
@eileenmcnaughton I would note that I think this will cause HTTP 500 errors to be thrown rather than HTTP 200 back to the IPN
There was a problem hiding this comment.
@seamuslee001 - except you already merged the try-catch to wrap around it
There was a problem hiding this comment.
ah ok I guess so right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code cleanup
Before
Unreachable code muddying the waters
After
poof
Technical Details
loadObjects is only called from one place. As we can see the contribution object is
always passed in so we don't need to handle the possibility of it being anything other than a
BAO (I tweaked the error handling around that line too to make it clearer where it was
coming from)
Comments