dev/core#1989 - E_WARNING when editing custom field with logging turned on

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/1989

1. Turn on logging (admin - system settings - misc).
2. Turn off popups so you can see the warning (admin - customize - display prefs) (or install the loudnotices extension).
3. Edit an existing custom field, e.g. just change the label, or don't even do anything and just click save.
4. ==> Notice: Undefined index: ADD
5. ==> Warning: Invalid argument supplied for foreach()

Technical Details

When there isn't anything to add to the table the array is empty.

Comments

Has test.
With whitespace ignored it's a one-line change.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

jenkins retest this please

[seamuslee001]

Looks fine to me merging

[demeritcowboy]

Thanks!