dev/core#1980 Move tax handling from line item api to BAO to make it available from apiv4 #18352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
3e21819 to
1c4d07a
Compare
|
@colemanw once this is merged we can add the v4 api |
|
@eileenmcnaughton I expected to see a removal too for a code move but this is just adding code in the BAO? |
|
@mattwire that looks like a mistake! fixing now |
… apiv4 This implementation has some limitations. I only address one in this PR - removing the rounding - as the focus of the PR is the move. The rounding from all save layers was previously removed but it was reverted when it was eroneously believed to have caused a bug. The bug turned out to be civicrm#18297
1c4d07a to
07ebcb2
Compare
|
Jenkins re test this please |
|
@seamuslee001 it has passed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Move tax handling from line item api to BAO to make it available from apiv4
Before
Calculation of tax_amount for line items at the api layer
After
Moved to the BAO
Technical Details
This implementation has some limitations. I only address one in this PR - removing the rounding - as
the focus of the PR is the move.
The rounding from all save layers was previously removed but it was reverted when it was eroneously believed
to have caused a bug. The bug turned out to be #18297
Comments
Test is in #18351 - which can be merged first as it is a refactor-support-test to ensure no change