Display url_site and url_recur based on if the form elements exist

[mattwire]

Overview

The payment processor configuration form has a number of elements that are not used for quite a few processors (eg. Stripe).

For Stripe those elements are:

• Credit card types (not used)
• Site URL (hardcoded via sdk)
• Recur URL (not used)

Other processors work in a similar way and might want to hide these elements.

Before

Form elements can be removed via buildForm hook but remnants remain (help icon).

After

Form elements can be removed via buildForm and disappear properly. No impact on saving.

Technical Details

For testing add the following to your buildForm hook:

    case 'CRM_Admin_Form_PaymentProcessor':
      foreach (['accept_credit_cards', 'url_site', 'url_recur', 'test_url_site', 'test_url_recur'] as $element)
      if ($form->elementExists($element)) {
        $form->removeElement($element);
      }
      break;

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Ok without test - entirely tpl layer

[seamuslee001]

This looks fine to me

[artfulrobot]

@mattwire just to note your "after" screenshot now includes "select credit card types..." text with no way to select credit card types.