Clean money for non-deductible amount #18300
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The Contribution API cleans money inputs for 3 of the 4 money fields. This corrects the inconsistency and adds tests for all four.
Before
"Non-deductible amount" treated differently than "fee amount", "net amount", and "total amount".
After
Consistent treatment.
Comments
The easiest way to replicate this is with the command line:
Be sure to read the data back out again rather than relying on the output of the command above, which isn't definitive!