Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean money for non-deductible amount #18300

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

MegaphoneJon
Copy link
Contributor

Overview

The Contribution API cleans money inputs for 3 of the 4 money fields. This corrects the inconsistency and adds tests for all four.

Before

"Non-deductible amount" treated differently than "fee amount", "net amount", and "total amount".

After

Consistent treatment.

Comments

The easiest way to replicate this is with the command line:

cv api Contribution.create total_amount=\$10 fee_amount=\$5 non_deductible_amount=\$4 financial_type_id=1 contact_id=1

Be sure to read the data back out again rather than relying on the output of the command above, which isn't definitive!

@civibot
Copy link

civibot bot commented Aug 31, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

Thanks @MegaphoneJon

@eileenmcnaughton eileenmcnaughton merged commit 82b571c into civicrm:master Aug 31, 2020
@eileenmcnaughton
Copy link
Contributor

Thanks @MegaphoneJon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants