Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/event#37 Add CONTAINS operator for APIv4 & Search #18285

Merged
merged 3 commits into from
Aug 30, 2020

Conversation

colemanw
Copy link
Member

Overview

Fixes https://lab.civicrm.org/dev/event/-/issues/37
Allows searching within arrays or serialized strings via API & new Search extension.

Before

Could not search within multivalued fields.

After

CONTAINS operator searches within arrays and serialized fields.

Technical Details

I left the json handling off for now, until we bump the minimum mysql version.

@civibot
Copy link

civibot bot commented Aug 29, 2020

(Standard links)

@civibot civibot bot added the master label Aug 29, 2020
@eileenmcnaughton
Copy link
Contributor

Code seems sensible, no existing tests were changed to support this so I'm comfortable it is only new functionality, which is tested

@eileenmcnaughton eileenmcnaughton merged commit 14c9482 into civicrm:master Aug 30, 2020
@eileenmcnaughton eileenmcnaughton deleted the contains branch August 30, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants