report#47 Report Bookkeeping add time field for date filter. #18268
Conversation
|
(Standard links)
|
| @@ -300,8 +300,7 @@ public function __construct() { | |||
| 'operatorType' => CRM_Report_Form::OP_INT, | |||
| 'type' => CRM_Utils_Type::T_INT, | |||
| ], | |||
| 'receive_date' => ['operatorType' => CRM_Report_Form::OP_DATE], | |||
| 'receipt_date' => ['operatorType' => CRM_Report_Form::OP_DATE], | |||
There was a problem hiding this comment.
Are we removing receipt_date?
There was a problem hiding this comment.
re-added receipt_date
| @@ -536,8 +537,10 @@ public function where() { | |||
| $relative = $this->_params["{$fieldName}_relative"] ?? NULL; | |||
There was a problem hiding this comment.
@sunilpawar everything above this line looks fine. But on the where clause - could we just stop overriding it?
We'd need to add an implementation of whereClause() to add the handling of
'credit_accounting_code',
'credit_name',
'credit_contact_id',
There was a problem hiding this comment.
@eileenmcnaughton added these field in whereClause clause .
Existing functionality does work by giving date range with time but it always from 20200827000000 to 20200827235959 , there was no control on time field to specify it.
There was a problem hiding this comment.
@sunilpawar thanks for confirming - your final fix will fix more than just this report I think
… bookkeeping, re-added receipt_date
|
I pulled this down & was able to
The changes improve the code - Merge-on-pass |
|
test this please |
|
Test fail is unrelated |
Same issue : https://lab.civicrm.org/dev/report/-/issues/7 ,with some solution : #13571
But not its not working ..., Reason Parent Class
CRM_Utils_Type::T_DATE + CRM_Utils_Type::T_TIMETime handling changed.Add Time field and Add Sort on Contribution Receive Date and Transaction Date.
https://lab.civicrm.org/dev/report/-/issues/47