Use already determined value for contributionRecurID

[eileenmcnaughton]

Overview

Just eliminates a place where $objects is referred to as we have already determined the value from $objects

Before

$contributionRecurID not used

After

$contributionRecurID used

Technical Details

I think we should move to passing in more $ids and less $objects. - Event & contribution are the only 2 objects currently where we are looking for more than just an id

Ie we would call it like

    CRM_Contribute_BAO_Contribution::completeOrder($input, [
      'related_contact' => $ids['related_contact'] ?? NULL,
      'participant' => isset($objects['participant']) ? $objects['participant']->id : NULL,
      'contributionRecur' => isset($objects['contributionRecur']) ? $objects['contributionRecur']->id : NULL,
    ], $objects);

The 2 remaining objects (event & contribution) we would probably load within completeOrder & not pass in $objects at all - but a little more work to confirm that. I think fixing batchUpdate to not call completeOrder (with tests) would simplify)

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

Agree