Remove 1 of 2 remaining places where relatedObjects is called in completeOrder #18257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
mattwire
reviewed
Aug 26, 2020
CRM/Contribute/BAO/Contribution.php
Outdated
| $contribution->trxn_id = $input['trxn_id'] ?? NULL; | ||
| $contribution->receive_date = CRM_Utils_Date::isoToMysql($contribution->receive_date); | ||
| } | ||
| $contribution->trxn_id = $input['trxn_id'] ?? NULL; |
There was a problem hiding this comment.
@eileenmcnaughton This line can go too - we don't pass $contribution by reference anymore and the only place it's passed is later in this function to CRM_Activity_BAO_Activity::addActivity which doesn't use trxn_id.
There was a problem hiding this comment.
yep agree - I've removed it. CRM_Activity_BAO_Activity::addActivity requires a lot of our remaining vars
|
@eileenmcnaughton Agree - can you see if you come to the same conclusion about the trxn_id line? |
…leteOrder If we remove this & the other place we no longer need to call loadRelatedObjects before this function and only message related places call it In this case the lines can go as 1) trxn_id should always be used if provided. Casting to isoDate has not been required for a few years as the DAO now handles
07fe8a9 to
c4c5eb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor cleanup - removes lines that are doing anything
Before
More cruft
After
Less
Technical Details
If we remove this & the other place we no longer need to call loadRelatedObjects before this
function and only message related places call it
In this case the lines can go as
years as the DAO now handles
Comments