Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Ensure that the form param _id is set when adding a new group w… #18250

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

seamuslee001
Copy link
Contributor

…ith the newly created group id so that consumers of the hook_civicrm_postProcess can access the id

Overview

This ensures that the form parameter $this->_id is set to the newly created id / the id of the current group so that hook_civicrm_postProcess consumers can use it in their code

Before

_id parameter not always set

After

_id parameter always set when we get to postProcess

ping @eileenmcnaughton @Edzelopez @mattwire

…ith the newly created group id so that consumers of the hook_civicrm_postProcess can access the id
@civibot
Copy link

civibot bot commented Aug 25, 2020

(Standard links)

@civibot civibot bot added the master label Aug 25, 2020
@eileenmcnaughton
Copy link
Contributor

Well there is precedent for this on other forms & the reason is commented so I guess it's fine

@eileenmcnaughton eileenmcnaughton merged commit 8f4d065 into civicrm:master Aug 25, 2020
@eileenmcnaughton eileenmcnaughton deleted the ref_entity_id_group branch August 25, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants