APIv4 - Fix output of CustomValue create/save/update

[colemanw]

Overview

Fixes the APIv4 output when saving custom pseudo-entities

Before

Output was the fairly useless [is_error => 0, result => true]

After

Outputs the actual values of the data saved, including the id. This is standard across other entities in the API.

Technical Details

In doing this I updated the internal CRM_Core_BAO_CustomValueTable::setValues() function to throw exceptions instead of returning errors, as that's been the goal for quite a while. We'll see what the tests think.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Well tests have passed here @colemanw is this mergable?

[colemanw]

@eileenmcnaughton do you feel good about switching to throw here?

[eileenmcnaughton]

@colemanw yes- but we throw CRM_Core_Exception not just Exception. You could argue the reason but it's our current convention & we should argue the reason in gitlab before changing

[colemanw]

Ok, FYI the reason I did that was because it was calling CRM_Core_Error::createAPIError which does throw Exception. But I agree that's better. Will rebase.

[eileenmcnaughton]

Looks like we are close to fully removing createAPIError