E_NOTICE on contribution page widget tab

[demeritcowboy]

Overview

Create a new contribution page and go to the widget tab.

Trying to get property 'id' of non-object in CRM_Contribute_Form_ContributionPage_Widget->preProcess() (line 43 of .../CRM/Contribute/Form/ContributionPage/Widget.php)

You don't see it though because it's hidden by ajax. You can see it in drupal watchdog.

Technical Details

It's because $this->_widget is null if it's a new contribution page or you've never configured the widget, but then it tries to set the widgetExternUrl using $this->_widget->id.

Comments

Has test

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Thanks @demeritcowboy

[demeritcowboy]

Thanks!