Put mysql back in civicrm.settings.php template #18188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Reverts #18097 which was only ever in master, to make it consistent with idea that while technically the DSN is a pear::db string, "mysql" means "use whatever works" as far as civi is concerned.
php-mysql was removed in php 7.0, but civi still converts "mysql" to "mysqli" if you have DB_DSN_MODE=='auto' (the default). This doesn't guarantee people will always have "mysql" in their settings file - I've manually updated it to mysqli before - but keeps the default consistent.
Side-note: When installing with civicrm-setup you can put "banana://" and it will still work for the install part.
Technical Details
See also a48a43c#diff-893853f109566b29f9edd6aa9b1d1523R195