Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put mysql back in civicrm.settings.php template #18188

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

demeritcowboy
Copy link
Contributor

@demeritcowboy demeritcowboy commented Aug 18, 2020

Overview

Reverts #18097 which was only ever in master, to make it consistent with idea that while technically the DSN is a pear::db string, "mysql" means "use whatever works" as far as civi is concerned.

php-mysql was removed in php 7.0, but civi still converts "mysql" to "mysqli" if you have DB_DSN_MODE=='auto' (the default). This doesn't guarantee people will always have "mysql" in their settings file - I've manually updated it to mysqli before - but keeps the default consistent.

Side-note: When installing with civicrm-setup you can put "banana://" and it will still work for the install part.

Technical Details

See also a48a43c#diff-893853f109566b29f9edd6aa9b1d1523R195

@civibot
Copy link

civibot bot commented Aug 18, 2020

(Standard links)

@civibot civibot bot added the master label Aug 18, 2020
@eileenmcnaughton
Copy link
Contributor

@totten do you agree we should actually revert this?

@demeritcowboy
Copy link
Contributor Author

FYI I took this comment #18174 (comment) as a hint:

IMHO, it's preferable to support DSN's with the mysql:// notation - on account of the install-base, downstream+upstream installer scripts, and general aesthetics. Tying Civi's stored-configurations to mysqli:// means it'll break again whenever php.net gets tired of maintaining mysqli and PDO-MySQL concurrently.

@seamuslee001
Copy link
Contributor

Merging as I think this is consistent with Tim's comment

@seamuslee001 seamuslee001 merged commit 66ef7c4 into civicrm:master Aug 19, 2020
@demeritcowboy demeritcowboy deleted the mysqli-mysql branch August 19, 2020 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants