Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(NFC) Update various DAO checksums #18184

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Conversation

totten
Copy link
Member

@totten totten commented Aug 18, 2020

Overview

Updates the checksums for autogenerated files.

Before

After running civibuild reinstall <name> or setup.sh, there are uncommitted changes.

$ git status
...
modified:   CRM/Contribute/DAO/ContributionPage.php
modified:   CRM/Core/DAO/Phone.php
modified:   CRM/Event/DAO/Event.php
modified:   CRM/Price/DAO/PriceFieldValue.php

After

DAOs match.

There is no substantive change.

Technical Details

I didn't track down why the checksums changed. Odds are some underlying template was updated in a way which causes a superficial change (eg perhaps whitespace in the first-pass of code-generation?). Don't think it matters - since the change is visibly NFC.

@civibot
Copy link

civibot bot commented Aug 18, 2020

(Standard links)

@civibot civibot bot added the master label Aug 18, 2020
@colemanw
Copy link
Member

Maybe happened when I resolved merge-conflicts in #18135

@seamuslee001 seamuslee001 merged commit 62fd88b into civicrm:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants