Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more appropriate money format function #18151

Merged
merged 1 commit into from
Aug 15, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 14, 2020

Overview

Use a preferred function to format currency only without currency symbols

Screen Shot 2020-08-15 at 11 50 26 AM

Screen Shot 2020-08-15 at 11 54 26 AM

Before

Abuses CRM_Utils_Money::format by passing in a blank locale

After

Uses the appropriate function formatLocaleNumericRoundedForDefaultCurrency

Technical Details

@seamuslee001 I think this one works

Comments

@civibot
Copy link

civibot bot commented Aug 14, 2020

(Standard links)

@seamuslee001
Copy link
Contributor

Tested this on my local and confirmed that it produces the same output and correctly localizes the amount

@seamuslee001 seamuslee001 merged commit d734dd3 into civicrm:master Aug 15, 2020
@seamuslee001 seamuslee001 deleted the money branch August 15, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants