Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate/remove unused checkVersion() functions #18134

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Deprecate/remove unused checkVersion() functions #18134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions CRM/Core/DAO.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1181,15 +1181,12 @@ public static function checkTableHasData($tableName) {

/**
* @param $version
*
* @deprecated
* @return bool
*/
public function checkVersion($version) {
$query = "
SELECT version
FROM civicrm_domain
";
$dbVersion = CRM_Core_DAO::singleValueQuery($query);
CRM_Core_Error::deprecatedFunctionWarning('CRM_Core_BAO_Domain::version');
$dbVersion = CRM_Core_BAO_Domain::version();
return trim($version) == trim($dbVersion);
}

Expand Down
13 changes: 0 additions & 13 deletions CRM/Upgrade/Form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,19 +286,6 @@ public function logVersion($newVersion) {
return FALSE;
}

/**
* @param $version
*
* @return bool
*/
public function checkVersion($version) {
$domainID = CRM_Core_DAO::getFieldValue('CRM_Core_DAO_Domain',
$version, 'id',
'version'
);
return (bool) $domainID;
}

/**
* @return array
* @throws Exception
Expand Down