[REF] Move isSSLDSN() function to avoid potential problems

[demeritcowboy]

Overview

This recently added function was put in CRM_Core_DAO just because of physical proximity to where it was being used. But this is less than 6 ft apart in violation of physical distancing precautions.

Before

Danger! Danger!

After

Normal civi levels of danger.

Technical Details

Even though all it does is parse a string, calling CRM_Core_DAO::anything triggers the constructor which triggers a database connection, which might not be what you want if you're still at the point of parsing the DSN string.

Function currently only used one place, inside CRM_Core_DAO. Straight up move to CRM_Utils_System which seems safe.

Comments

Added test.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@demeritcowboy is there a reason why your moving it to CRM_Utils_System rather than CRM_Utils_Sql?

[demeritcowboy]

Nope no reason, just overlooked it. Thanks.

[seamuslee001]

This looks fine to me now