dev/core#1934 fix regression on merging contacts with settings using contact_id #18126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is an interim fix to a reported regression. I'll look at more carefully in master when time permits
Before
Attempting to dedupe 2 contacts with settings with contact IDs will cause a fatal. My understanding is this would only be the case if an extension implemented it
After
Dedupe works
Technical Details
Comments