Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP notice on contribution page #18116

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

mattwire
Copy link
Contributor

Overview

When you have membership enabled and you want to switch to contributions you will get a PHP notice if you click "Save" because you can't enable the contributions block without disabling the membership block first and amount_block_is_active is not set.

Before

PHP notice

After

PHP notice gone

Technical Details

Comments

@civibot
Copy link

civibot bot commented Aug 10, 2020

(Standard links)

@civibot civibot bot added the master label Aug 10, 2020
@eileenmcnaughton eileenmcnaughton merged commit b88b5a5 into civicrm:master Aug 11, 2020
@eileenmcnaughton
Copy link
Contributor

I think enotices in form rules don't require tests - it's 'formy'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants