Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] [Test] Initial testing on event payment forms. #18112

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 10, 2020

Overview

Extension to testing of forms

Before

No testing on the event cart form, no testing of multi-form-flow

After

Preliminary tests in this area

Technical Details

I'm trying to work on improving our testing of payment forms. I started with 3 event forms but there were
enough challenges that for this commit I'm just adding tests on one form. As noted in the code comments
it makes sense for this test to be in the extension but I want to work through the challenges on the
other forms before finalising any helper functions to the point where they are available to extensions.

This is actually a bit of a break through as it's the first time we have testing on a form flow - ie
submitting the first form and then the second. It was quite painful

Comments

@civibot
Copy link

civibot bot commented Aug 10, 2020

(Standard links)

@civibot civibot bot added the master label Aug 10, 2020
@eileenmcnaughton eileenmcnaughton changed the title [Test] WIP [NFC] [Test] Initial testing on event payment forms. Aug 10, 2020
@eileenmcnaughton eileenmcnaughton force-pushed the paytest branch 4 times, most recently from 68c6e85 to 9b201b1 Compare August 10, 2020 04:21
I'm trying to work on improving our testing of payment forms. I started with 3 event forms but there were
enough challenges that for this commit I'm just adding tests on one form. As noted in the code comments
it makes sense for this test to be in the extension but I want to work through the challenges on the
other forms before finalising any helper functions to the point where they are available to extensions.

This is actually a bit of a break through as it's the first time we have testing on a form flow - ie
submitting the first form and then the second. It was quite painful
@seamuslee001
Copy link
Contributor

Test fail looks related @eileenmcnaughton

@eileenmcnaughton
Copy link
Contributor Author

yep damn it -

@eileenmcnaughton
Copy link
Contributor Author

OK that looks promising

@eileenmcnaughton eileenmcnaughton merged commit 9eb70b2 into civicrm:master Aug 10, 2020
@eileenmcnaughton eileenmcnaughton deleted the paytest branch August 10, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants