Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Serialize key to payment_processor field for Event & Contribution Page #18110

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 9, 2020

Overview

Minor code simplification - use metadata rather than code handling to save array of processors

Before

$params['payment_processor'] = implode(CRM_Core_DAO::VALUE_SEPARATOR, array_keys($params['payment_processor']));

After

Key defined

'serialize' => self::SERIALIZE_SEPARATOR_TRIMMED,

Technical Details

The DAO can handle arrays if it knows the format now...

Comments

I tested saving in both forms after making this change. However, the string still 'works' if another code place is passinng it in

…Page

The DAO can handle arrays if it knows the format now...
@civibot
Copy link

civibot bot commented Aug 9, 2020

(Standard links)

@civibot civibot bot added the master label Aug 9, 2020
@eileenmcnaughton eileenmcnaughton changed the title Add Serialize key to payment_processor field for Event & Contribution… Add Serialize key to payment_processor field for Event & Contribution Page Aug 9, 2020
@seamuslee001
Copy link
Contributor

I'm happy if the tests are

@seamuslee001 seamuslee001 merged commit 0c29b2e into civicrm:master Aug 10, 2020
@seamuslee001 seamuslee001 deleted the xml branch August 10, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants