Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variable #18108

Merged
merged 1 commit into from
Aug 9, 2020
Merged

Remove unused variable #18108

merged 1 commit into from
Aug 9, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

I spotted this variable as defined but unused - let's remove

Before

Screen Shot 2020-08-10 at 9 43 14 AM

After

Poof

Technical Details

Comments

@civibot
Copy link

civibot bot commented Aug 9, 2020

(Standard links)

@civibot civibot bot added the master label Aug 9, 2020
seamuslee001
seamuslee001 reviewed Aug 9, 2020
View reviewed changes
tests/phpunit/CRM/Financial/Form/PaymentFormsTest.php Outdated
@@ -0,0 +1 @@
<?php
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eileenmcnaughton should this have been committed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opps no

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seamuslee001 fixed

@eileenmcnaughton
Remove unused variable
eab134f 
I spotted this variable as defined but unused - let's remove
@seamuslee001 seamuslee001 merged commit 679cd9d into civicrm:master Aug 9, 2020
@seamuslee001 seamuslee001 deleted the paytest branch August 9, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seamuslee001 seamuslee001 seamuslee001 left review comments

Assignees
No one assigned
Labels
master merge on pass sig:code maintenance readability testability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001