Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv4 Explorer: Generate short cv code #18089

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Aug 6, 2020

Overview

Generates the clever shorthand cv code that @totten made.

Before

image

After

image

@civibot
Copy link

civibot bot commented Aug 6, 2020

(Standard links)

@civibot civibot bot added the master label Aug 6, 2020
@colemanw
Copy link
Member Author

colemanw commented Aug 6, 2020

@eileenmcnaughton does this help you hate APIv4 less on the CLI?

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

@colemanw yes- I'm not sure it goes far enough but I don't want perfect to be the enemy of the good on this one

@eileenmcnaughton
Copy link
Contributor

ok-without-test as outside tested / testable subsystems

@eileenmcnaughton eileenmcnaughton merged commit 212120e into civicrm:master Aug 6, 2020
@eileenmcnaughton eileenmcnaughton deleted the api4cv branch August 6, 2020 22:33
@totten
Copy link
Member

totten commented Oct 8, 2020

Ooooh, I didn't see this one back on August 6. I just wanna say "huzzah"

@colemanw
Copy link
Member Author

colemanw commented Oct 8, 2020

Thanks @totten.
Unfortunately there's a bug - APIv4 is strict about input types, which causes problems like this on the CLI:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants