dev/core#1930 fix for move-related checkbox being overridden to true …

[eileenmcnaughton]

Overview

Fixes a probable regression where deselecting 'move related contributions' etc does not block them being moved

ie activities are still transferred in this view

See: https://lab.civicrm.org/dev/core/-/issues/1930

Before

Deselection ignored

After

Deselection works

Technical Details

I haven't managed to determine when this changed but the method of

$element->setChecked(TRUE);

is happening in preProcess and overwriting the submission - moving to setDefaults works

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass - Explained on the linked Ticket
  • (r-user) Pass
  • (r-doc) Pass
  • (r-run) Pass I replicated the problem on local dev by unchecking activities but the activities were still brought across in a merge, Reverting the database then applying this patch kept the activities with their original contacts but other elements were merged correctly
  • (r-tech) Pass
  • (r-code) Pass
  • (r-maint) Pass
  • (r-test) Pass

[pfigel]

Thanks @eileenmcnaughton!

[eileenmcnaughton]

thanks for finding it! I still don't fully get it since other fields the same didn't get the bug - but I'm gonna do another cleanup on it & see if I can get them all to use setDefaults - but in master