Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Fix provider unit test on PHP7.4 #18073

Merged
merged 1 commit into from
Aug 5, 2020
Merged

[NFC] Fix provider unit test on PHP7.4 #18073

merged 1 commit into from
Aug 5, 2020

Conversation

seamuslee001
Copy link
Contributor

Overview

This fixes a test failure on PHP7.4 "trying to access array offset on value of type bool"

Before

Test fails on PHP7.4

After

Test passes on PHP7.4

ping @demeritcowboy @eileenmcnaughton @mattwire

@civibot
Copy link

civibot bot commented Aug 5, 2020

(Standard links)

@civibot civibot bot added the master label Aug 5, 2020
@eileenmcnaughton eileenmcnaughton merged commit 03cc26c into civicrm:master Aug 5, 2020
@eileenmcnaughton eileenmcnaughton deleted the provider_test_php74 branch August 5, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has-test master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @eileenmcnaughton