Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/drupal#131 Ensure that the General class exists #18066

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

seamuslee001
Copy link
Contributor

Overview

In some circumstances the General class hasn't been loaded (in the user's case running update.php) this mitigates by putting in a require once if the class doesn't exist

Before

Class may or may not exist

After

Class consistently exists

ping @eileenmcnaughton @demeritcowboy

@civibot
Copy link

civibot bot commented Aug 4, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

OK - seems like it solves a problem with no real downside - perhaps you could at least link back to the ticket by way of explanation though

@seamuslee001 seamuslee001 merged commit 534c8f4 into civicrm:5.28 Aug 4, 2020
@seamuslee001 seamuslee001 deleted the dev_drupal_131 branch August 4, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants