Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] remove first attempt to set currency in repeattransaction flow #18055

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 4, 2020

Overview

Removes code that no longer does anything

Before

contributionParams['currency'] set from a convoluted variable, but then overwritten in repeattransaction. For completetransaction is is not required as the contribution already has a saved currency

After

Test added, lines removed

Technical Details

The currency is retrieved from the template transaction, these lines are no longer needed, as demonstrated
in the test

Comments

Test cover in edited test & also in testRepeatTransactionWithDifferenceCurrency

@civibot
Copy link

civibot bot commented Aug 4, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

related fail - testRepeatTransactionWithDifferenceCurrency checking but good to note it covers

The currency is retrieved from the template transaction, these lines are no longer needed, as demonstrated
in the test
@mattwire mattwire merged commit 4743a93 into civicrm:master Aug 4, 2020
@eileenmcnaughton eileenmcnaughton deleted the curr_copy branch August 4, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants