[REF] remove first attempt to set currency in repeattransaction flow #18055
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes code that no longer does anything
Before
contributionParams['currency'] set from a convoluted variable, but then overwritten in repeattransaction. For completetransaction is is not required as the contribution already has a saved currency
After
Test added, lines removed
Technical Details
The currency is retrieved from the template transaction, these lines are no longer needed, as demonstrated
in the test
Comments
Test cover in edited test & also in testRepeatTransactionWithDifferenceCurrency