[REF] Remove transaction from BaseIPN completeTransaction call

[eileenmcnaughton]

Overview

[REF] Remove transaction from BaseIPN completeTransaction call

A grep looks like this - note the Contribution/Confirm class has a different function with the same name

Before

public function completeTransaction(&$input, &$ids, &$objects, $transaction = NULL) {

After

public function completeTransaction(&$input, &$ids, &$objects) {

Technical Details

This is no longer ever passed in

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 this is now possible with those other PRs meaning it no longer reaches this function

[seamuslee001]

@eileenmcnaughton I did a grep around the universe and the only one that turned up something interesting was sagepay https://github.com/circleinteractive/uk.co.circleinteractive.payment.sagepay/blob/master/custom/php/CRM/Core/Payment/Sagepay/IPN.php#L403

[seamuslee001]

I think this is probably safe none the less and it seems the sagepay extension hasn't been updated for a while