[Ref] Simplify is_email_receipt in sendMail #18029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function has evolved through refactoring so there was a time when this code needed to decide whether to send emails out or not. However, the function is now called more deliberately -ie 1) from completeTransaction - where it is only called if the decision to send an email is made 2) from the search action send Email receipts - where a user has made the decision to send (or pdf) receipts and unless it's being called with returnMessageText = TRUE (to construct a pdf) then send makes sense Ergo we should send unless returnMessageText = TRUE
|
(Standard links)
|
b79ad34 to
081ee44
Compare
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes legacy handling from BAO_Contribution::sendMail
Before
The function attempts to calculate whether it actually should send mail
After
The function trusts it's caller.
Technical Details
This function has evolved through refactoring so there was a time when this code needed to decide whether to
send emails out or not. However, the function is now called more deliberately -ie
receipts and unless it's being called with returnMessageText = TRUE (to construct a pdf) then
send makes sense
Ergo we should send unless returnMessageText = TRUE
Comments