CRM_Core_BAO_Cache - Remove functions deprecated a year ago

[eileenmcnaughton]

Overview

Remove functions deprecated a year ago in the CRM_Core_BAO_Cache class

Before

After

Poof

Technical Details

These have been spitting out deprecation notices for a year

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton test fails relate

[totten]

Yeah, a year is a pretty fair wind-down period (esp considering that the transition actually started a few years before the official deprecation).

I did a grep on a recent universe for references to the deprecated CRM_Core_BAO_Cache::setItem, ::getItem, and ::deleteGroup -- and these were the only repos that still needed an update:

• https://github.com/greenleafadvancement/com.greenleafadvancement.donorsearch (ping @deepak-srivastava)
• https://github.com/compucorp/civihr (ping @jamienovick)
• https://github.com/catorghans/net.trinfinity.orgis.mi.dataquality (ping @catorghans)

The required updates should be pretty simple - i.e. swapping CRM_Core_BAO_Cache with Civi::cache(...), e.g.

• If you just need to store 1 or 2 bespoke items in a SQL cache, then use Civi::cache('long').
• If you need to access the cache-group-formally-known-as contact fields, then use Civi::cache('fields').

[eileenmcnaughton]

Thanks @totten - I think you ping on top of a year of noisy deprecation notices should be enough. I've fixed the tests

[totten]

Test failure looks unrelated. We've given a small pause on the pings, but I don't really expect pushback, and those new filings by @eileenmcnaughton were good idea.

Merging.