Fixed filling default values for tagssets in the advanced search form

[kainuk]

Overview

The edit smart group form does not fill the default values for tag sets.

Reproduction steps

1. Create a tag set. This can be done in the civicrm/tag?reset=1 form. Example:
   

2. Now the tagset shows up in the advanced search:
   

3. Create smart group from this advanced search. This smart group works fine

4. Go to the smart group settings screen (1 - Manage Smart Groups, 2 - Go to the settings form of the smart group , 3 Click Edit Smart Group Criteria)

5. Now you cannot see what values of the tagset are chosen.

Current behavior

Expected behavior

This is needed to know what the original selection was

Environment information

Reproduced on the master 5.29.alpha1.

Comments

Related to https://lab.civicrm.org/dev/core/-/issues/1542

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[jaapjansma]

• General standards
  • Explain (r-explain)
    • PASS : The goal/problem/solution have been adequately explained in the PR. Wel done @kainuk
  • User impact (r-user)
    • PASS: The change would be unnoticeable for a majority of users who work with this feature.
  • Documentation (r-doc)
    • PASS: The changes do not require documentation.
  • Run it (r-run)
    • PASS: We run this PR in a test environment and in dmaster and we can confirm it works as expected.
• Developer standards
  • Technical impact (r-tech)
    • PASS: The change preserves compatibility with existing callers/code/downstream.
  • Code quality (r-code)
    • PASS: The functionality, purpose, and style of the code seems clear+sensible.
  • Maintainability (r-maint)
    • PASS: The change is trivial enough that it does not require tests.
  • Test results (r-test)
    • PASS: The test results are all-clear.

@eileenmcnaughton or @mattwire could one of you merge this PR?

[eileenmcnaughton]

Thanks @jaapjansma !

[kainuk]

This bug was fixed for the European trade union institute. https://www.etui.org/). Is it possible to acknowledge this in the Release Notes?

[eileenmcnaughton]

@agh1 ^^

[agh1]

@kainuk @eileenmcnaughton we haven't been including acknowledgments for organizations that fund bug fixes or features. There would be many in each release, I'm sure. I'm not opposed in principle to doing it in the future, but we'd need a much more elaborate system of crediting akin to what Drupal does because it would be unrealistic to read through all PR comments and issues to find a mention of a funder. For now, all we can do is credit the authors of the commits and any commenters on the pull requests, each with their primary organizational affiliation.